Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 add docs for releasing cluster-stack-operator #79

Merged
merged 2 commits into from
May 27, 2024
Merged

📖 add docs for releasing cluster-stack-operator #79

merged 2 commits into from
May 27, 2024

Conversation

kranurag7
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
chess-knight
chess-knight approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michal-gubricky
michal-gubricky approved these changes Mar 1, 2024
View reviewed changes
Copy link

@michal-gubricky michal-gubricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jschoone
Copy link
Contributor

Hi @kranurag7, is that still a Draft?

@kranurag7
Copy link
Contributor Author

Hi @kranurag7, is that still a Draft?

I wanted to add a note and I've done that via 94b951a

Now, I'll mark this ready for review.

@kranurag7 kranurag7 marked this pull request as ready for review May 27, 2024 06:49
@jschoone
Copy link
Contributor

jschoone commented May 27, 2024 •
edited

Hi @kranurag7, is that still a Draft?

I wanted to add a note and I've done that via 94b951a

Now, I'll mark this ready for review.

Thanks @kranurag7. Question to you and @batistein (as requested for review): are those approvals still up-to-date? If yes, please merge.

EDIT: sorry, hit return accidentely

@kranurag7
add docs for releasing cluster-stack-operator
dc00bed 
Signed-off-by: kranurag7 <anurag.kumar@syself.com>
@kranurag7
add note about updating metadata.yaml
76681e2 
Signed-off-by: kranurag7 <anurag.kumar@syself.com>
@kranurag7
Copy link
Contributor Author

Yes, I think the approvals are still up to date here but still let's go through it again.

@chess-knight @michal-gubricky I added on more commit about updating metadata.yaml when we change the minor version for the release.

76681e2

Please review it again and upon approval, let's get this patch merged into main.

@kranurag7 kranurag7 merged commit 7397ff7 into main May 27, 2024
4 checks passed
@kranurag7 kranurag7 deleted the kr/add-release-docs branch May 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batistein batistein batistein approved these changes

@chess-knight chess-knight chess-knight approved these changes

@michal-gubricky michal-gubricky michal-gubricky approved these changes

Assignees
No one assigned
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document how to release cluster-stack-operator
5 participants
@kranurag7 @jschoone @batistein @chess-knight @michal-gubricky